system-variables: improve restricted-read-only docs (#8401) #8406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
area/sql-infra
16 tasks
ti-chi-bot
added
type/cherry-pick-for-release-6.0
TomShawn
reviewed
Apr 28, 2022
TomShawn
reviewed
May 9, 2022
TomShawn
approved these changes
May 9, 2022
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d2a004a
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8401
What is changed, added or deleted? (Required)
The docs for
tidb_restricted_read_onlyare inconsistent:The type for this variable is a boolean, which in
SHOW VARIABLEScontext will showONorOFF. InSELECT @@varnamecontext it will return0or1, so for docs context we have to chose one format.It looks like the original PR author chose
0/1, but in the rest of the page we useON/OFF, which is also consistent with the mysql docs: https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.htmlWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
This was added in #7670 (2 days ago)
Do your changes match any of the following descriptions?